Repository navigation
Omitting fetcher function argument is ambiguous? #148
Description
Activity
yes it is ambiguous, thanks for noting! We need to document and maybe add some tests so it's clear. It should be:
- To only retrieve a swrv cache response without revalidating, you can omit the fetcher function from the useSWRV call + To only retrieve a swrv cache response without revalidating, you can set the fetcher function to `null` from the useSWRV call
If it is "omitted" (aka
undefined) then the Fetch api will be used.Line 189 in bd6c7e6
Reacted by Tomáš Mládek, Adam DeHaven and Danny AhnRelevant swr issue: vercel/swr#738
This is great, but the typings for it do not allow
null, it should be a quick fix to just addnullto the type definition.Reacted by Tomáš Mládek, Jaka Stavanja and Danny AhnMy PR resolves typing problem.
#274Current doc is not ambiguous for me, function calls
f(),f(undefined)andf(undefined, undefined)have the same arguments (geek note: except argument length). In JS, omitting argument always means supplyingundefined.Yeah, but I think it's good to clarify the doc.
afaik, the
nullfetcher behaves likePromise.race([])or() => new Promise<never>(() => {})(meaning resolves after infinite minutes), butisVaildatingvalue differs.
The README states:
But later also:
So, which one is it? :) Or am I misunderstanding what omitting means in the first case?