Community Feedback #1

Activity

1. jhpratt commented on May 25, 2021

   

   jhpratt

   on May 25, 2021

   More actions

   I haven't had a chance to test this out yet, but I think having TryFrom impls could be quite convenient. It would avoid the match with a single type expected with the rest panicking (.expect could be used or some other error handling).
2. LukasKalbertodt commented on May 25, 2021

   

   LukasKalbertodt

   on May 25, 2021

   Last edited by LukasKalbertodt

   OwnerAuthor

   More actions

   I assume you are talking about TryFrom<X> for Y where Y is litrs::StringLit, litrs::IntegerLit and so on? That's a great idea! What could X be then? proc_macro[2]::Literal for sure. But also String and &str? Probably all four options, right?

   EDIT: no, I wasn't thinking straight. The &str and String cases are already covered by parse, of course. But yeah, for the proc_macro[2]::Literal types it makes perfect sense!
3. jhpratt commented on May 25, 2021

   

   jhpratt

   on May 25, 2021

   More actions

   I was imagining proc_macro::Literal and proc_macro::TokenTree (along with proc_macro2 equivalents).
4. LukasKalbertodt commented on May 25, 2021

   

   LukasKalbertodt

   on May 25, 2021

   OwnerAuthor

   More actions

   Yeah TokenTree also makes sense. Sweet, thanks.
5. LukasKalbertodt commented on May 28, 2021

   

   LukasKalbertodt

   on May 28, 2021

   OwnerAuthor

   More actions

   @jhpratt I just published 0.2.0 which contains a large number of From and TryFrom impls. It was actually more work than expected, but I think they really improve the library and make lots of real world uses cases easier. Thanks for the suggestion again!

   👍React with 👍1Reacted by Jacob Pratt
6. wycats commented on Oct 2, 2021

   

   wycats

   on Oct 2, 2021

   More actions

   @LukasKalbertodt I stumbled across this crate and really love it. Thank you so much for doing this!

   ❤️React with ❤️1Reacted by Lukas Kalbertodt
7. xiyuzhai commented on Dec 26, 2022

   

   xiyuzhai

   on Dec 26, 2022

   Last edited by xiyuzhai

   More actions

   I'm working on my own programming language https://github.com/xiyuzhai-husky-lang/husky/. I shall work out the literal part of my language based on this project. Amazing work!!!
8. LukasKalbertodt commented on Oct 20, 2025

   

   LukasKalbertodt

   on Oct 20, 2025

   OwnerAuthor

   More actions

   Thanks again for your feedback! I just released v1.0 and will close this open ended issue. Of course, feedback is still appreciated as separate issues, for example.
9. LukasKalbertodt

   closed this as completedon Oct 20, 2025