feat: duration vaults #1671

eigenmikem · 2025-12-01T17:55:49Z

Motivation:

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications:

Describe the modifications you've done.

Result:

After your change, what will change.

ypatil12

Looks good! General state machine + readability improvements. Big question is still around guarantees we need around staker delegation at the time of deposit.

src/contracts/interfaces/IStrategyFactory.sol

src/contracts/strategies/DurationVaultStrategy.sol

0xrajath · 2025-12-02T19:32:40Z

src/contracts/strategies/StrategyFactory.sol

+        require(!isBlacklisted[underlyingToken], BlacklistedToken());
+        require(address(durationVaultBeacon) != address(0), DurationVaultBeaconNotSet());
+
+        newVault = IDurationVaultStrategy(


Do we want these to be deterministic deploys?

src/contracts/interfaces/IDurationVaultStrategy.sol

0xrajath · 2025-12-02T19:35:44Z

src/contracts/interfaces/IDurationVaultStrategy.sol

+        address newVaultAdmin
+    ) external;
+
+    function vaultAdmin() external view returns (address);


Instead of vaultAdmin, is it worth just inheriting Ownable? Reduces the surface area of code IMO.

Do we want it to be transferable?

Don't think we need it to be transferrable? Fine to just leave as an immutable at deploy

src/contracts/interfaces/IDurationVaultStrategy.sol

ypatil12 · 2025-12-03T14:11:06Z

src/contracts/interfaces/IDurationVaultStrategy.sol

+        address newVaultAdmin
+    ) external;
+
+    function vaultAdmin() external view returns (address);


Don't think we need it to be transferrable? Fine to just leave as an immutable at deploy

src/contracts/strategies/DurationVaultStrategy.sol

ypatil12 · 2025-12-03T14:19:18Z

src/contracts/strategies/DurationVaultStrategy.sol

+     * @notice Locks the vault, preventing new deposits and withdrawals until maturity.
+     */
+    function lock() external override onlyVaultAdmin {
+        require(_state == VaultState.Deposits, VaultAlreadyLocked());


Do we want a startTime for the vault? Unsure what the user story is for when the vault can begin allocation

Having a unique start time per vault enables each vault to have a deterministic deployment... again unsure if that's a relevant user story

We used to have defined deposit windows but removed to make things easier for AVSs. Insurance AVS can lock at an arbitrary time but it's expected they will say publicly

src/contracts/strategies/DurationVaultStrategy.sol

Did not mean to approve

src/contracts/strategies/DurationVaultStrategy.sol

src/contracts/strategies/DurationVaultStrategyStorage.sol

ypatil12

Will review the integration tests a bit later

src/contracts/interfaces/IDurationVaultStrategy.sol

src/contracts/strategies/DurationVaultStrategy.sol

src/contracts/interfaces/IStrategy.sol

src/contracts/strategies/DurationVaultStrategy.sol

ypatil12 · 2025-12-15T16:52:14Z

src/contracts/strategies/DurationVaultStrategy.sol

+        _;
+    }
+
+    constructor(


Do we need to set the operator fee here for rewards? Operators (and this strategy) by default get 10% of rewards. We don't have a way of claiming those rewards with the current implementation. Should the fee just be set to zero since presumably the operator and AVS are the (same?) entity? cc @non-fungible-nelson

It's set in configureOperatorIntegration

Gotcha. Btw, it takes 7 days for this fee to become active on mainnet. We should document this as an edge case if the allocation state ends up being hit prior to the fee becoming active

i guess allocation delay is 14 days , so this won't be possible?

This is the activationDelay:

eigenlayer-contracts/src/contracts/core/RewardsCoordinator.sol

Lines 308 to 325 in 8e25c9d

/// @inheritdoc IRewardsCoordinator

function setOperatorPISplit(

address operator,

uint16 split

) external onlyWhenNotPaused(PAUSED_OPERATOR_PI_SPLIT) checkCanCall(operator) {

uint32 activatedAt = uint32(block.timestamp) + activationDelay;

uint16 oldSplit = _getOperatorSplit(_operatorPISplitBips[operator]);

_setOperatorSplit(_operatorPISplitBips[operator], split, activatedAt);

emit OperatorPISplitBipsSet(msg.sender, operator, activatedAt, oldSplit, split);

}

/// @inheritdoc IRewardsCoordinator

function setOperatorSetSplit(

address operator,

OperatorSet calldata operatorSet,

uint16 split

) external onlyWhenNotPaused(PAUSED_OPERATOR_SET_SPLIT) checkCanCall(operator) {

Also, need to set the operator PI split to 0.

Assuming this strategy doesn't get PI? Probably something to validate with product.

i mean , split is set on initialization and after 7 days it becomes active

allocation in the other hand will be active only after allocation delay (14 days after lock ) which we set in initialization as well ,so by the time of reward , the split will be active cause rewards only starts after allocation is active (correct?)

Yup, good point. So we should be fine here :)

ypatil12 · 2025-12-15T16:57:52Z

src/test/integration/tests/DurationVaultIntegration.t.sol

@@ -0,0 +1,466 @@
+// SPDX-License-Identifier: BUSL-1.1


For sanity, in the upgrade folder can we add an upgrade test against a deposit that is before the upgrade for already existing strategies (Eigen strat, strategy factory, and tvl limits)

Deposit into strategy, upgrade, queue withdrawal (tests remove shares), complete withdrawal as shares (tests add shares)

script/releases/v1.11.0-duration-vault/2-queueUpgrade.s.sol

script/releases/v1.10.0-duration-vault/3-completeUpgrade.s.sol

script/releases/CoreUpgradeQueueBuilder.sol

script/releases/v1.11.0-duration-vault/2-queueUpgrade.s.sol

ypatil12 · 2025-12-16T18:00:09Z

src/contracts/strategies/StrategyFactory.sol

        _transferOwnership(_initialOwner);
        _setPausedStatus(_initialPausedStatus);
        _setStrategyBeacon(_strategyBeacon);
+        if (address(_durationVaultBeacon) != address(0)) {


Seems unnecessary if we don't check strategyBeacon is address(0)?

elhajin · 2025-12-17T08:30:37Z

src/contracts/strategies/StrategyBase.sol

    function explanation() external pure virtual override returns (string memory) {
        return "Base Strategy implementation to inherit from for more complex implementations";
    }


you may override the explanation function to return an explanation of the duration vault strategy, it's weird that it returns baseStrategy explanation

elhajin · 2025-12-17T08:32:00Z

src/contracts/strategies/DurationVaultStrategy.sol

+        delegationManager = _delegationManager;
+        allocationManager = _allocationManager;
+        rewardsCoordinator = _rewardsCoordinator;


add _disableInitializers() to the constructor for impl

elhajin · 2025-12-17T08:33:40Z

src/contracts/strategies/StrategyFactory.sol

+    function getDurationVaults(
+        IERC20 token
+    ) external view returns (IDurationVaultStrategy[] memory) {
+        return durationVaultsByToken[token];
+    }


this is the only way to fetch the duration vaults for a token, but it can lead to OOG issue for on-chain integrations, specially that anyone can increase the length of the array, by creating a new duration vaults.

consider making the durationVaultsByToken public for safe on-chain reads

elhajin · 2025-12-17T08:35:19Z

src/contracts/strategies/DurationVaultStrategy.sol

+    function allocationsActive() public view override returns (bool) {
+        return _state == VaultState.ALLOCATIONS;


note that this doesn't always means that allocation on AM is active, since we have a delay of minWithdrawalDelayBlocks()

elhajin · 2025-12-17T08:36:36Z

src/contracts/strategies/DurationVaultStrategyStorage.sol

+    /// Storage slots used: vaultAdmin (1) + duration/lockedAt/unlockAt/maturedAt/_state (packed, 1) +
+    /// metadataURI (1) + _operatorSet (2) + maxPerDeposit (1) + maxTotalDeposits (1) = 8.
+    /// Gap: 50 - 8 = 42.
+    uint256[42] private __gap;


__gap should be 44 , (50 - 6 )

elhajin · 2025-12-17T08:50:29Z

script/releases/v1.11.0-duration-vault/1-deployContracts.s.sol

+        assertTrue(
+            address(Env.impl.strategyManager()) != address(0), "StrategyManager implementation should be deployed"
+        );
+        assertTrue(
+            address(Env.impl.strategyManager().delegation()) == address(Env.proxy.delegationManager()),
+            "StrategyManager: delegationManager mismatch"
+        );
+
+        // Validate EigenStrategy
+        assertTrue(address(Env.impl.eigenStrategy()) != address(0), "EigenStrategy implementation should be deployed");


If deployment fails silently, Env.impl.* falls back to the old mainnet address from environment variables which won't be address(0) for most

better to add :

function _validateDeployedContracts() internal view { + assertEq(deploys().length, 7, "Deployed contracts should be 7");

eigenmikem added 6 commits December 1, 2025 09:48

feat: duration vaults

91119b7

chore: fmt

66c3316

chore: fmt

f18ac88

fix: fix storage layout

a1fa83b

refactor: AM integration

80efea9

chore: fmt

daf709d

ypatil12 reviewed Dec 2, 2025

View reviewed changes

0xrajath reviewed Dec 2, 2025

View reviewed changes

src/contracts/interfaces/IDurationVaultStrategy.sol Outdated Show resolved Hide resolved

0xrajath reviewed Dec 2, 2025

View reviewed changes

eigenmikem added 4 commits December 2, 2025 17:49

refactor: storage contract

3c5d172

refactor: opset ds

c3b46f6

chore: error messages

f42059c

Merge branch 'main' into mike/duration-strategy

a6b0bc4

ypatil12 previously approved these changes Dec 3, 2025

View reviewed changes

eigenmikem added 2 commits December 3, 2025 13:43

refactor: remove unneeded helpers

6ae6c8d

chore: remove unneeded error

0334bb2

eigenmikem changed the base branch from main to release-dev/duration-vaults December 4, 2025 15:02

eigenmikem added 7 commits December 4, 2025 17:48

refactor: changeable TVL limits

baeae24

test: integration tests

f345dfe

chore: remove junk

4a422b1

test: fork test fix

a10cab3

test: fork test fix 2

478eb77

chore: fix fork 3

9ea4b2d

chore: revert

c7497d3

elhajin reviewed Dec 11, 2025

View reviewed changes

eigenmikem added 3 commits December 11, 2025 17:39

refactor: SM hooks and tests'

2743e8d

refactor: PR comments

70b7d41

test: fork test fix

6a157d3

eigenmikem added 5 commits December 11, 2025 19:49

fix: fork test fix

99fca5d

fix: fix rewards fork test

44ac0d6

refactor: security review

b5f4711

feat: rewards coordinator split set

32430e4

chore: deploy from scratch

6f4ad90

ypatil12 reviewed Dec 15, 2025

View reviewed changes

eigenmikem added 4 commits December 15, 2025 12:07

feat: deploy scripts

a36026a

chore: fix deploy script

345173a

fix: PR comments

c5f4575

docs: natspec

d9ba985

ypatil12 reviewed Dec 15, 2025

View reviewed changes

eigenmikem added 7 commits December 15, 2025 13:48

fix: fork test fix

83d2530

refactor: deploy scripts

a3c5ddd

fix: fix deploy script version check

0f181de

refactor: change deploy versioning

90aa728

refactor: reinitialize pattern

a8d9f2e

chore: test ownership fix

37f27e3

fix: 1.9 protocol registry fix

8829ce2

ypatil12 reviewed Dec 16, 2025

View reviewed changes

eigenmikem force-pushed the mike/duration-strategy branch from fb1301d to 8829ce2 Compare December 16, 2025 18:10

elhajin reviewed Dec 17, 2025

View reviewed changes

eigenmikem added 2 commits December 17, 2025 11:06

refactor: rewards 1.9 fix and 1.11 versioning checks

d9f5c62

refactor: immutable beacons

19285b2

	/// @inheritdoc IRewardsCoordinator
	function setOperatorPISplit(
	address operator,
	uint16 split
	) external onlyWhenNotPaused(PAUSED_OPERATOR_PI_SPLIT) checkCanCall(operator) {
	uint32 activatedAt = uint32(block.timestamp) + activationDelay;
	uint16 oldSplit = _getOperatorSplit(_operatorPISplitBips[operator]);
	_setOperatorSplit(_operatorPISplitBips[operator], split, activatedAt);

	emit OperatorPISplitBipsSet(msg.sender, operator, activatedAt, oldSplit, split);
	}

	/// @inheritdoc IRewardsCoordinator
	function setOperatorSetSplit(
	address operator,
	OperatorSet calldata operatorSet,
	uint16 split
	) external onlyWhenNotPaused(PAUSED_OPERATOR_SET_SPLIT) checkCanCall(operator) {

		function allocationsActive() public view override returns (bool) {
		return _state == VaultState.ALLOCATIONS;

feat: duration vaults #1671

Are you sure you want to change the base?

feat: duration vaults #1671

Uh oh!

Conversation

eigenmikem commented Dec 1, 2025

Uh oh!

ypatil12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ypatil12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ypatil12 Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

ypatil12 Dec 15, 2025 •

edited

Loading

ypatil12 Dec 15, 2025 •

edited

Loading