Skip to content

[0.19] Implement API for analytics of votes given by a person #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: release/v0.19
Choose a base branch
from
Draft

[0.19] Implement API for analytics of votes given by a person #5669

wants to merge 3 commits into from

Conversation

@MrKaplan-lw
Copy link

@MrKaplan-lw MrKaplan-lw commented May 8, 2025 •
edited
Loading

This contains some rather complex SQL, but it's not possible to simply replicate that with Diesel without losing performance or consistency afaik.

@Nutomic
Copy link
Member

Nutomic commented May 9, 2025

Generally new features should be on the main branch, otherwise it will be a lot of hassle to keep bug fixes and enhancements in sync across 0.19 and main.

@MrKaplan-lw
Copy link
Author

MrKaplan-lw commented May 9, 2025

my development target is currently 0.19, as that is the version we run on lemmy.world.
when the 0.19 PR is acceptable overall I can create an additional PR against main, but it will duplicate my work having to do all those adjustments on two branches before it's ready.
this code is already applied as a patch to lemmy.word with some minor differences, so the 0.19 code doesn't need extra effort for backporting from that.
as this only impements new functionality and doesn't change any existing APIs there should be minimal differences to what would be applied to main anyway.

Nutomic
Nutomic reviewed May 9, 2025
View reviewed changes
@Nutomic
Copy link
Member

Nutomic commented May 9, 2025

Makes sense. Do you also have some tool to visualize the output of this endpoint? If so it would be nice if we could see some example screenshots.

@MrKaplan-lw
Copy link
Author

MrKaplan-lw commented May 9, 2025 •
edited
Loading

image

this is what i got so far, i'll see about having post and comment votes in tables next to each other.

Fedihosting-Foundation-Forks/lemmy-ui@5093717...30f0ea6

@MrKaplan-lw MrKaplan-lw force-pushed the vote-analytics-given-by-person branch from 444fa0c to 790f50a Compare May 12, 2025 19:55
@MrKaplan-lw MrKaplan-lw mentioned this pull request Sep 1, 2025
Open
@Nutomic Nutomic mentioned this pull request Nov 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nutomic Nutomic Nutomic left review comments

@dessalines dessalines Awaiting requested review from dessalines dessalines will be requested when the pull request is marked ready for review dessalines is a code owner

@phiresky phiresky Awaiting requested review from phiresky phiresky will be requested when the pull request is marked ready for review phiresky is a code owner

@dullbananas dullbananas Awaiting requested review from dullbananas dullbananas will be requested when the pull request is marked ready for review dullbananas is a code owner

@SleeplessOne1917 SleeplessOne1917 Awaiting requested review from SleeplessOne1917 SleeplessOne1917 will be requested when the pull request is marked ready for review SleeplessOne1917 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MrKaplan-lw @Nutomic