Updated wasm support for cognito-idp 4.0.0#78
Conversation
|
@EpicSquid why the removal of |
|
It's only necessary if someone is using the JS library from JS. In kotlin it works fine. My build only worked with the wasm component when the JS Export tag was removed which was true in the previous branch and, as far as I understand, they aren't necessary anyway. If it's a key requirement for this to work from JS then I can take another look and see why it might be happening, could be a shared source set issue since the js exports specifically work differently with wasm. |
|
@EpicSquid my team is currently checking than out but I fear that we need the |
|
Oh that's very fair using it with solid, hadn't thought of that. I have an idea I'll try in a day or 2 to fix this. |
This reverts commit 776f501.
Should be the exact same final functionality on the JS side. This is the only way to add wasm support while maintaining js support.
|
This should fix the issue. The core problem is that on JS @JsExport works on classes, but on wasm it doesn't. Given that the JS client already exists we can leverage that and put all the JsExport annotations in the JS project only, and have mappers on the kotlin side to translate between as needed. |
|
@EpicSquid seems that there exist some errors in the code, sry I have to manually start the build & test action https://github.com/Liftric/cognito-idp/actions/runs/18924710132/job/54168680728 |
|
Tests fixed, should be good now |
|
What's the chance you can send me the error file that is generated from the runner? I can't replicate it locally as I don't have the secrets to test with so I can't tell what the issue is |
When I run your branch here in GitHub Actions, our secrets are ignored. I received these error messages locally when running the test: I'm not very familiar with this project, but I tried a few things to resolve the Errors in I guess it is because of this part, the commonTests seems to need the Base64 decode implementation for wasm |
Added wasm support for cognito idp as per previous closed request.
Updated to use cognito-idp 4.0.0. Feedback welcome.