Fix re-export sorter #2065
Merged
Fix re-export sorter #2065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
==========================================
+ Coverage 98.80% 99.28% +0.48%
==========================================
Files 38 38
Lines 3084 3088 +4
Branches 745 746 +1
==========================================
+ Hits 3047 3066 +19
+ Misses 26 13 -13
+ Partials 11 9 -2 |
I'm not sure where the best place is for this, so I placed it around various options similar to it (at least as far as I can tell).
|
Thanks for the fix. Looking forward to it! |
|
@timothycrosley Sorry for the ping, can I request this be reviewed/merged? It would be good to have the working version of this feature available for the general userbase to use, especially for those that have asked about it. |
|
It would be great to have this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR changes
Fixes a big where the line would be duplicated rather than sorted
Allows for unbracketed tuples to be sorted
Allows sets of re-exports to be sorted
Allows literals to be sorted even if there are no spaces between the variable name and the literal
Renames numerous variables tied to the re-exporter for clarity
Regarding point 4
Previously, isort would not be able to sort the following code:
Now, it sorts it like so:
Related issues
Closes #1887.
Closes #1971.
Closes #2037.