rasterio 1.4.0/1.4.1 flips y-axis in compute_availabilitymatrix
#420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compute_availabilitymatrixcompute_availabilitymatrix
lkstrp
approved these changes
Jan 3, 2025
Member
There was a problem hiding this comment.
Quite a random find, great!
I think this is also what's causing the pypsa-eur problems, which is why we've pinned it to rasterio==1.4.1 right now. Do you think this could be solved with a fix in atlite or do we need to upload updated cutouts somewhere as well?
At least hopefully it does.
EDIT: Hmm, it can't be the former, I'll check the cached cutouts.
Member
Author
|
I don't think the cutouts are affected by this. |
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a random find, but caused some significant faults in renewable potential calculations...
Versions 1.4.0 and 1.4.1 or
rasteriocause a flipped y-axis incutout.compute_availabilitymatrix(), which neither earlier nor later versions ofrasteriodo. With no changes but changed rasterio version:With
rasterio==1.4.{0,1}With
rasterio<1.4,>=1.4.2I think excluding these versions makes more sense than implementing version-specific behavior in
atlite.