-
Notifications
You must be signed in to change notification settings - Fork 68
add linear expression from constant #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add linear expression from constant #518
Conversation
|
I notice an issue that if there is a linear expression that only contains constants, some of the methods seem a bit strange. |
FabianHofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice and clean
ah right, I haven't thought about that. I guess we would need to fix that one in particular. would you be able to do so? (could also be a follow up) |
4aebe03 to
1eddef9
Compare
|
@FabianHofmann I made some fixes to the "to_polars" thing for Linear and Quadratic expressions that are constant |
|
@FabianHofmann ready to merge if you are happy with it |
|
@RobbieKiwi I took the freedom to push some fixes. would merge when the ci is through |
Closes #513
Closes #517
Changes proposed in this Pull Request
Add
LinearExpression.from_constantNow constraints just containing constants cannot be created
Checklist
doc.doc/release_notes.rstof the upcoming release is included.