Skip to content

Add GoalQuery to PGM api#987

Merged
Electroid merged 2 commits into
PGMDev:devfrom
KingOfSquares:goalquery-api
May 13, 2022
Merged

Add GoalQuery to PGM api#987
Electroid merged 2 commits into
PGMDev:devfrom
KingOfSquares:goalquery-api

Conversation

@KingOfSquares

Copy link
Copy Markdown
Contributor

@Pablete1234 Pablete1234 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use probably be using generics as they are meant to be used, not just as wildcards everywhere

Comment thread core/src/main/java/tc/oc/pgm/api/filter/query/GoalQuery.java Outdated
Comment thread core/src/main/java/tc/oc/pgm/filters/query/GoalQuery.java Outdated
Comment thread core/src/main/java/tc/oc/pgm/filters/query/GoalQuery.java Outdated
Comment thread core/src/main/java/tc/oc/pgm/filters/query/GoalQuery.java Outdated
@KingOfSquares

Copy link
Copy Markdown
Contributor Author

You should use probably be using generics as they are meant to be used, not just as wildcards everywhere

Good point.

Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
@Pablete1234 Pablete1234 added the ready PR is ready to merge label May 12, 2022
@Electroid Electroid merged commit ea2bb37 into PGMDev:dev May 13, 2022
@KingOfSquares KingOfSquares deleted the goalquery-api branch May 19, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PR is ready to merge

Development

Successfully merging this pull request may close these issues.

3 participants