Skip to content

[Install]remove utils and third_party in paddlespeech's site-packages#2867

Merged
yt605155624 merged 1 commit into
PaddlePaddle:developfrom
yt605155624:rm_utils_in_setup
Feb 1, 2023
Merged

[Install]remove utils and third_party in paddlespeech's site-packages#2867
yt605155624 merged 1 commit into
PaddlePaddle:developfrom
yt605155624:rm_utils_in_setup

Conversation

@yt605155624

@yt605155624 yt605155624 commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

If utils and third_party are installed in python's site-packages, they will be regarded as Python third-party library, which doesn't meet our expectations.

before fix:
ad2a9f39eb8e649e816db1253585d50f
after fix:
c377bb5bf93285e710123d144f304ae5

@yt605155624 yt605155624 added this to the r1.4.0 milestone Feb 1, 2023
@yt605155624 yt605155624 requested a review from SmileGoat February 1, 2023 08:48
@yt605155624 yt605155624 self-assigned this Feb 1, 2023

@SmileGoat SmileGoat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yt605155624 yt605155624 merged commit 896da6d into PaddlePaddle:develop Feb 1, 2023
@yt605155624 yt605155624 deleted the rm_utils_in_setup branch February 1, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants