This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Multi label support#52
Merged
Merged
Conversation
Marked old fields, getter & setter as deprecated
Owner
Author
|
I would be super thankfully if someone can test this with the Export-Document, this is the last thing we need to test =) |
This was referenced Sep 23, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finished the multi-label support (also for other functions, which allows multiple requests in one call)
Sadly I cannot test everything, so I would love to get some feedback about those:
createShipmentstill workscreateShipmentworks with multiple elementscreateShipmentshows multiple labels in ResponsecreateShipmentworks with "ExportDocument"createShipmentshows the "ExportDocument" in ResponsecreateShipmentworks with "COD (Cash on delivery)"createShipmentshows the "COD (Cash on delivery)" label in responsedoManifeststill worksdoManifestworks with multiple elementsdoManifestshows result(s) in ResponsedeleteShipmentstill worksdeleteShipmentworks with multiple elementsdeleteShipmentshows the result(s) in ResponsegetShipmentLabelstill worksgetShipmentLabelworks with multiple elementsgetShipmentLabelshows the result(s) in ResponsegetExportDocstill worksgetExportDocworks with multiple elementsgetExportDocshows the result(s) in ResponsevalidateShipmentstill worksvalidateShipmentworks with multiple elementsvalidateShipmentshows the result(s) in ResponseJust use the "multi-label" Branch for testing my changes.
I made some bigger changes, so I want to ensure everything works, before merging. I will merge, when every * element is tested