Add a handling for the null case when flattening over the map of settings, for example when initial_recovery = null after copying or recovering an index #3308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings, for example when initial_recovery = null after copying or recovering an index
|
Is it possible to add a test case? |
|
I can add a test, sure, but I need to create an index and then clone it and can you correct me if I am wrong but I don't see any methods for using the Clone API? Either way it can be testable, just might take a minute to create the supporting functions as well. |
|
Unless you are happy with unit tests, which is also an option, just testing the flatten function |
|
I think a unit test would be fine. Indeed, we don't have the Clone API yet. |
|
Added a test, let me know if there is anything else. I will also implement the CloneAPI hopefully soon. Will update on that when it is ready |
|
Can you format the code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.