fix: boosting query parameters #3385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f0c0fa to
6938802
Compare
Philippus
requested changes
Apr 25, 2025
- Removed not used queryName field, - Removed incorrect boost field, - Made required negativeBoost field. https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-boosting-query.html#boosting-top-level-params Previously it was possible to create boosting query with incorrect body, for example with field boost that doesn't exist, or without required negativeBoost.
|
Sure, done, there are some failing tests but not from me |
|
I'll add a PR on top of this PR to facilitate with migration. |
Philippus
pushed a commit
that referenced
this pull request
May 7, 2025
- Removed not used queryName field, - Removed incorrect boost field, - Made required negativeBoost field. https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-boosting-query.html#boosting-top-level-params Previously it was possible to create boosting query with incorrect body, for example with field boost that doesn't exist, or without required negativeBoost. (cherry picked from commit fcd4421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queryNamefield,boostfield,negativeBoostfield.https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-boosting-query.html#boosting-top-level-params
Previously it was possible to create boosting query with incorrect body, for example with field
boostthat doesn't exist, or without requirednegativeBoost.