feat: added matched queries to inner hit #3538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible for you to add a test case for this situation? |
|
@Philippus I just added a test case for the matched queries 👍 |
|
Hey @Philippus any updates on this one? Is something blocking it from getting merged? |
Philippus
approved these changes
Jul 31, 2025
Philippus
pushed a commit
that referenced
this pull request
Jul 31, 2025
* feat: added matched queries to inner hit * feat: added test case for matched queries (cherry picked from commit d6e7be7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
matchedQueriesto theInnerHit. Matched queries cannot just exist in the top levelSearchHitbut also in Inner Hits when having a Named Query in a nested structure. Until now it was not possible to retrieve the matched queries from an inner hit.