Skip to content

Fix double encoding path for http4s client #3620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

Fix double encoding path for http4s client #3620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adbd741
Fix double encoding path
Sep 9, 2025
1b43723
fix formating
Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elastic4s-client-http4s/src/main/scala/com/sksamuel/elastic4s/http4s/Http4sClient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ object Http4sClient {
endpoint: ElasticNodeEndpoint
): Http4sClient[F] = {
val uri = http4s.Uri(
scheme = Some(http4s.Uri.Scheme.http),
scheme = endpoint.prefix.flatMap(http4s.Uri.Scheme.fromString(_).toOption),
authority = Some(http4s.Uri.Authority(host = http4s.Uri.RegName(endpoint.host), port = Some(endpoint.port)))
)
new Http4sClient(
Expand Down
3 changes: 2 additions & 1 deletion ...lient-http4s/src/main/scala/com/sksamuel/elastic4s/http4s/RequestResponseConverters.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ trait RequestResponseConverters extends Elastic4sEntityEncoders {
): http4s.Request[F] = {
val uri =
endpoint.copy(
path = http4s.Uri.Path(request.endpoint.stripPrefix("/").split('/').map(http4s.Uri.Path.Segment(_)).toVector),
path =
http4s.Uri.Path(request.endpoint.stripPrefix("/").split('/').map(http4s.Uri.Path.Segment.encoded).toVector),
query = http4s.Query.fromPairs(request.params.toList: _*)
)

Expand Down
6 changes: 6 additions & 0 deletions ...ent-http4s/src/test/scala/com/sksamuel/elastic4s/http4s/Http4sRequestHttpClientTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,10 @@ class Http4sRequestHttpClientTest extends AnyFlatSpec with Matchers with DockerT
}.unsafeRunSync().result.status shouldBe "401"
}

it should "be able index document with id properly" in {
val id = "id://test-id"
ioClient.execute {
indexInto("testindex").withId(id)
}.unsafeRunSync().result.id shouldBe id
}
}