Skip to content

Add all parameter to PatternReplaceTokenFilter #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
+26 −2
Merged

Add all parameter to PatternReplaceTokenFilter #3655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions elastic4s-domain/src/main/scala/com/sksamuel/elastic4s/analysis/TokenFilter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,19 +363,25 @@ case class HunspellTokenFilter(
def dictionary(dictionary: String): HunspellTokenFilter = copy(dictionary = dictionary.some)
}

case class PatternReplaceTokenFilter(override val name: String, pattern: String, replacement: String)
extends TokenFilter {
case class PatternReplaceTokenFilter(
override val name: String,
pattern: String,
replacement: String,
all: Option[Boolean] = None
) extends TokenFilter {

override def build: XContentBuilder = {
val b = XContentFactory.jsonBuilder()
b.field("type", "pattern_replace")
b.field("pattern", pattern)
b.field("replacement", replacement)
all.foreach(b.field("all", _))
b
}

def pattern(p: String): PatternReplaceTokenFilter = copy(pattern = p)
def replacement(r: String): PatternReplaceTokenFilter = copy(replacement = r)
def all(all: Boolean): PatternReplaceTokenFilter = copy(all = all.some)
}

case class CommonGramsTokenFilter(
Expand Down
7 changes: 7 additions & 0 deletions ...c4s-tests/src/test/resources/json/analysis/tokenfilter/patternreplacetokenfilter_raw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "pattern_replace",
"pattern": "[£|€]",
"replacement": "",
"all": false
}

11 changes: 11 additions & 0 deletions elastic4s-tests/src/test/scala/com/sksamuel/elastic4s/analysis/TokenFilterTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,17 @@ class TokenFilterTest extends AnyWordSpec with Matchers with JsonSugar {
}
}

"PatternReplaceTokenFilter" should {
"build json" in {
PatternReplaceTokenFilter(
name = "my_pattern_replace",
pattern = "[£|€]",
replacement = "",
all = Some(false)
).build.string should matchJsonResource("/json/analysis/tokenfilter/patternreplacetokenfilter_raw.json")
}
}

"EdgeNGramTokenFilter" should {
"build json" in {
EdgeNGramTokenFilter(
Expand Down