Skip to content

[0.8] Undefined method in constructor #1207

Closed
Closed
[0.8] Undefined method in constructor#1207
Assignees
sjmiles
Labels
0.8

Description

@robdodson
robdodson
opened on Feb 20, 2015

Given this sample element:

var XBaz = Polymer({

  is: 'x-baz',

  constructor: function(name) {
    var el = document.createElement(this.is);
    el.name = name;
    el.createTextContent(el.name);
    return el;
  },

  createTextContent: function(name) {
    this.textContent = 'Hello, from ' + name;
  }

});

var el = new XBaz('x-baz');
document.body.appendChild(el);

I get an error saying createTextContent is an undefined function.

Activity

  1. peterwmwong commented on Feb 20, 2015

    @peterwmwong
    peterwmwong
    on Feb 20, 2015
    Contributor

    @robdodson I think this is the same as #1151. I do have a PR for this #1152, which does seem to fix your testcase above: http://jsbin.com/nitedo/5/edit?html,output

  2. robdodson
    assigned
    sjmiles
    on Feb 20, 2015
  3. justinfagnani
    added
    0.8
    on Feb 28, 2015
  4. sorvell
    added
    0.8
    and removed
    0.8
    on Mar 5, 2015

  5. kevinpschaaf commented on Mar 9, 2015

    @kevinpschaaf
    kevinpschaaf
    on Mar 9, 2015
    Member

    Fixed in 24a2914 (didn't take PR #1152 as the implementation has changed a bit). Note the API change, such that the custom constructor need not call document.createElement and return the element. This will be done automatically; the user constructor should only configure the instance (this).

  6. kevinpschaaf
    closed this as completedon Mar 9, 2015

  7. kevinpschaaf commented on Mar 9, 2015

    @kevinpschaaf
    kevinpschaaf
    on Mar 9, 2015
    Member

    New API looks like this: http://jsbin.com/nijiyohoqa/2/edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

0.8

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions