Repository navigation
attributeChanged is not called under some circumstances #438
Description
Activity
example is a little bit complicated than i describe.ill try to reproduce this in a simple way (i'm not able to publish part of the project).
Example:
http://jsbin.com/buqeturu/1/editbut i could find polymer-flex-layout.html in CDN.
Steps to reproduce: click "show 1", "show 2", "show 1".
after last click method layoutContainerChanged inside polymer-flex-layout is not called for component inside polymer-test1
The binding mechanism that controls things like
layoutContainerChangedis unbound asynchronously after the element is detached. If indetached, you callthis.cancelUnbindAll, thelayoutContainerChangedbindings will survive after being detached, and work again when re-attached.<polymer-flex-layout>does not call this method indetached, and that's a bug.Thanks for reporting this!
After discussing this with @frankiefu and @sorvell, I remember why
<polymer-flex-layout>does not keep its bindings: we can't determine if you will add the element back, or let it be garbage collected.Because MDV must keep references to the element to process data binding, we have to dispose of the data bindings on removal from the DOM, or there will be a memory leak.
Therefore, you have to be the one to call
cancelUnbindAllin your application if you hold on to an element after you have removed it from the DOM and need the bindings to work.Whenever javascript gains a Weak Reference, or MDV becomes native, then we can remove this restriction.
@ebidel This seems like an important topic to cover in the databinding docs (probably in big text).
We have extensive docs on "life of a binding" here:
http://www.polymer-project.org/docs/polymer/polymer.html#bindingsThis will probably find its way into the data-binding docs after they're revamped.
When Element created dynamically and appended to the dom:
var el = new PolymerSampleElement();
document.body.appendChild(el);
method attributeChanged called.
then you remove this element from the dom:
document.body.removeChild(el);
when you try to add, already created, element back to the dom method attributeChanged is not called.