Skip to content

Conversation

@semanticdreamer
Copy link

Thank you Danilo for the nice project idea and easily approachable ESP32 setup! 👍

Here are some initial contributions that you might want to consider, or not.

I used them to familiarize myself with the code base and project structure. Also, I had to adapt the base URL to the EU data region anyway.

Changes:

  • FIX, minor, typo in filename
  • NEW added config option for BASE_URL to portal (defaulting to US data region)
  • CHANGE Refactored JS code to async/await
  • NEW added SSID to config API and make current wifi network selected option

Corrects a typo in the header file include path.
Ensures the correct WifiInterface header is included.
Adds the ability to configure a custom base URL for the PostHog API, e.g. data regions EU or US or self-hosted.

This allows users to specify a different PostHog instance or a proxy server to be used for API requests.

Validates that the base URL ends with `/api/projects/` and persists it in the configuration.
The API key and base URL are now required for the system to be considered fully ready.
Improves user experience by providing a placeholder
value for the base URL input field, guiding the user
on the expected format.
Adds the stored Wi-Fi SSID to the device configuration for
pre-selection in the captive portal UI, enhancing user experience.
The password field is masked for security.
Converts form submission functions to use async/await for improved readability and error handling.
Adds try/catch blocks to handle potential errors during fetch requests, displaying an error message to the user.

The 'refreshNetworks' function now accepts config to preselect SSID if available.
Modifies form submission handlers to prevent default form
submission, ensuring JavaScript functions handle the
submission process. This change avoids unexpected page
reloads and ensures proper form data handling.
daniloc pushed a commit that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant