-
Notifications
You must be signed in to change notification settings - Fork 24
feat: insight-query tool #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new insight-query tool that allows LLMs to execute queries on existing insights and retrieve their results/data. This fills a gap where insights could be created and managed but their actual data couldn't be queried for decision-making in agent workflows.
- Adds a new
queryInsightToolthat takes an insight ID and returns both insight metadata and query results - Extends the API client with a
querymethod to execute insight queries - Includes comprehensive integration tests for the new functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
typescript/src/tools/insights/query.ts |
Implements the core insight query tool with handler logic |
typescript/src/tools/index.ts |
Registers the new query insight tool |
typescript/src/schema/tool-inputs.ts |
Defines the schema for insight query parameters |
typescript/src/api/client.ts |
Adds API client methods and schema updates for querying insights |
typescript/tests/tools/insights.integration.test.ts |
Adds integration tests for the query functionality |
schema/tool-inputs.json |
JSON schema definition with additional optional parameters |
schema/tool-definitions.json |
Tool definition for the insight-query tool |
typescript/src/tools/dashboards/get.ts |
Unrelated change that appears incomplete |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jonathanlab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incredibly cool, good one!
Add a tool to be able to query existing insights, as there was currently no way to do this.
It will allow insight data to impact the decisions made by an LLM during agent workflows.