Make name variable of Behavior open#906
Merged
Merged
Conversation
Generated by 🚫 Danger |
ikesyo
approved these changes
Sep 7, 2019
| /** | ||
| Override this variable if you want to provide custom name for this example group. | ||
| */ | ||
| open class var name: String { return String(describing: self) } |
Member
There was a problem hiding this comment.
This is exactly what I thought before and is not a breaking change, so it's safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is a byproduct of my article about using
Behaviorin Quick.I believe the
namevariable ofBehaviorshould beopenso it's possible to override it and provide custom name, if needed.