Propagate DAGCircuit.name in ApplyLayout
#13910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has always been absent, but `transpile` masked the problem by assigning the output circuit names by overwriting the `output_names` input kwarg if it wasn't set. `generate_preset_pass_manager` didn't have the same logic, so it was observable that `ApplyLayout` didn't propagate the name. We could have added similar name-propagation logic to `generate_preset_pass_manager`, but really the bug is in `ApplyLayout`; passes _should_ propagate the metadata.
Collaborator
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13507255486Details
💛 - Coveralls |
jlapeyre
previously requested changes
Feb 23, 2025
Contributor
jlapeyre
left a comment
There was a problem hiding this comment.
I made one minor correction and a question on a minor point. Other than that it looks good.
kevinhartman
approved these changes
Feb 24, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
* Propagate `DAGCircuit.name` in `ApplyLayout` This has always been absent, but `transpile` masked the problem by assigning the output circuit names by overwriting the `output_names` input kwarg if it wasn't set. `generate_preset_pass_manager` didn't have the same logic, so it was observable that `ApplyLayout` didn't propagate the name. We could have added similar name-propagation logic to `generate_preset_pass_manager`, but really the bug is in `ApplyLayout`; passes _should_ propagate the metadata. * Fix typo Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> * Remove redunant set --------- Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> (cherry picked from commit 29aa2bd) # Conflicts: # test/python/transpiler/test_preset_passmanagers.py
jakelishman
added a commit
that referenced
this pull request
Feb 25, 2025
* Propagate `DAGCircuit.name` in `ApplyLayout` This has always been absent, but `transpile` masked the problem by assigning the output circuit names by overwriting the `output_names` input kwarg if it wasn't set. `generate_preset_pass_manager` didn't have the same logic, so it was observable that `ApplyLayout` didn't propagate the name. We could have added similar name-propagation logic to `generate_preset_pass_manager`, but really the bug is in `ApplyLayout`; passes _should_ propagate the metadata. * Fix typo Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> * Remove redunant set --------- Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> (cherry picked from commit 29aa2bd)
jakelishman
added a commit
that referenced
this pull request
Feb 25, 2025
* Propagate `DAGCircuit.name` in `ApplyLayout` This has always been absent, but `transpile` masked the problem by assigning the output circuit names by overwriting the `output_names` input kwarg if it wasn't set. `generate_preset_pass_manager` didn't have the same logic, so it was observable that `ApplyLayout` didn't propagate the name. We could have added similar name-propagation logic to `generate_preset_pass_manager`, but really the bug is in `ApplyLayout`; passes _should_ propagate the metadata. * Fix typo Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> * Remove redunant set --------- Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> (cherry picked from commit 29aa2bd)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
* Propagate `DAGCircuit.name` in `ApplyLayout` This has always been absent, but `transpile` masked the problem by assigning the output circuit names by overwriting the `output_names` input kwarg if it wasn't set. `generate_preset_pass_manager` didn't have the same logic, so it was observable that `ApplyLayout` didn't propagate the name. We could have added similar name-propagation logic to `generate_preset_pass_manager`, but really the bug is in `ApplyLayout`; passes _should_ propagate the metadata. * Fix typo Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> * Remove redunant set --------- Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> (cherry picked from commit 29aa2bd) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has always been absent, but
transpilemasked the problem by assigning the output circuit names by overwriting theoutput_namesinput kwarg if it wasn't set.generate_preset_pass_managerdidn't have the same logic, so it was observable thatApplyLayoutdidn't propagate the name.We could have added similar name-propagation logic to
generate_preset_pass_manager, but really the bug is inApplyLayout; passes should propagate the metadata.Summary
Details and comments