Fix Sabre rebuild with nested Var and Stretch (backport #14488)
#14493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Cherry-pick of 985bd7a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
440ea32 to
ea8adc6
Compare
The `empty_dag` helper, used to construct control-flow blocks, in the rebuilder failed to account for `Var` or `Stretch` nodes. We have integration tests in `test/python/compiler/test_transpiler.py` that _in theory_ should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them.
ea8adc6 to
23e2851
Compare
jakelishman
previously approved these changes
May 28, 2025
Pull Request Test Coverage Report for Build 15306595671Details
💛 - Coveralls |
jakelishman
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
empty_daghelper, used to construct control-flow blocks, in the rebuilder failed to account forVarorStretchnodes. We have integration tests intest/python/compiler/test_transpiler.pythat in theory should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them.Summary
Details and comments
This fixes the test failures that #14484 turned up.
This is an automatic backport of pull request #14488 done by [Mergify](https://mergify.com).