Fix more spurious complex parts in circuit functions #14431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
One or more of the following people are relevant to this code:
|
Member
|
Should this be backported to 2.0.2? |
Collaborator
Author
|
Whoops, wrong target branch -- this was supposed to go on |
Pull Request Test Coverage Report for Build 15188244278Details
💛 - Coveralls |
ElePT
approved these changes
May 22, 2025
Contributor
ElePT
left a comment
There was a problem hiding this comment.
LGTM. I have confirmed that this fixes the primitives bug that triggered the issue.
Member
|
@Mergifyio backport stable/1.4 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2025
* Fix spurious complex part in circuit funcs * reno links (cherry picked from commit e7fa11d)
Contributor
|
@Mergifyio backport main |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2025
* Fix spurious complex part in circuit funcs * reno links (cherry picked from commit e7fa11d)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2025
#14455) * Fix more spurious complex parts in circuit functions (#14431) * Fix spurious complex part in circuit funcs * reno links (cherry picked from commit e7fa11d) * Add qpy compat test * Fix black * Fix lint, don't import circuit library element on older qiskit version * Remove venv * Fix indentation * Fix tests * Fix import * Fix access * debug * Change test * Restore backwards compat test * Remove reno --------- Co-authored-by: Julien Gacon <jules.gacon@googlemail.com> Co-authored-by: ElePT <epenatap@gmail.com> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
…#14431) (Qiskit#14455) * Fix more spurious complex parts in circuit functions (Qiskit#14431) * Fix spurious complex part in circuit funcs * reno links (cherry picked from commit e7fa11d) * Add qpy compat test * Fix black * Fix lint, don't import circuit library element on older qiskit version * Remove venv * Fix indentation * Fix tests * Fix import * Fix access * debug * Change test * Restore backwards compat test * Remove reno --------- Co-authored-by: Julien Gacon <jules.gacon@googlemail.com> Co-authored-by: ElePT <epenatap@gmail.com> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@ElePT reported that #13643 came back for other circuits, too. This essentially affects circuits that use operators as inputs, which have coefficients of complex types. This problem does not appear on
main, I assume #13278 removes the 0 complex component. We could still consider to add this safetyguard tomain, but there's no way to break it right now that I'm aware of.