Add CommutativeOptimization to transpiler pipeline
#15464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt transpiler pipeline for continuous basis sets
Collaborator
|
One or more of the following people are relevant to this code:
|
CommutativeOptimization to transpiler pipeline
| approximation_degree=pass_manager_config.approximation_degree | ||
| ), | ||
| InverseCancellation(), | ||
| ContractIdleWiresInControlFlow(), |
Contributor
There was a problem hiding this comment.
After ContractIdleWiresInControlFlow does CommutativeOptimization keep gates inside their original if_test block, or can it move gates between different if_test blocks?
Example:
if_test(cr): cx(0,1); h(1) # Block 1
if_test(cr): z(1); cx(0,1) # Block 2
Can it swap h(1)↔z(1) across blocks?
| init.append(CommutativeCancellation()) | ||
| else: | ||
| init.append(ConsolidateBlocks()) | ||
| init.append(CommutativeOptimization()) |
Contributor
There was a problem hiding this comment.
Just trying to understand the ConsolidateBlocks → CommutativeOptimization order. Is there any logic behind? Does ConsolidateBlocks first create larger blocks specifically to give CommutativeOptimization more gates to reorder? Why this sequence vs reverse?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #15452.
This PR replaces
CommutativeCancellationbyCommutativeOptimizationin the default compilation pipeline for continuous basis sets, which is relevant for optimization levels 2 and 3. This should provide higher quality results at similar runtimes.Since this is an important change, we did not want to do it late in 2.3, but it would be nice to do it early for 2.4, so that we have a sufficient time to test the impact.
Details and Comments:
We do not want to apply this change for Clifford+T transpilation, since we need to fully rethink that pipeline, and this is tracked independently in #15457.