[radar-redis] add network policy #6201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
ewelinagr
reviewed
Oct 28, 2025
| podSelector: | ||
| matchLabels: | ||
| {{ include "common.labels.matchLabels" . | indent 6 }} | ||
| {{- tpl (toYaml .Values.networkpolicy) . | nindent 2 }} |
There was a problem hiding this comment.
I think there is a problem here, as tpl would also include this custom line from .Values.networkpolicy:
enabled: true
I don't think it's a valid field in the Kubernetes NetworkPolicy.spec. Also, in other component's network policies we don't use enabled property, if we inject it to network policy with "tpl".
There was a problem hiding this comment.
Maybe remove the enabled and just use:
{{- if .Values.networkpolicy }}
check like in other network policies?
There was a problem hiding this comment.
@ewelinagr Fixed!
f25d9a4 to
021e8d7
Compare
ewelinagr
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add networkPolicy to the new radar-redis service. It also updates the netpol of existing services that connect to radar-redis.