Skip to content

Conversation

@keyvaann
Copy link
Collaborator

@keyvaann keyvaann commented Feb 13, 2023

Once this is implemented whenever we push a commit to main branch of this repository a pull request should automatically be created on RADAR-Kubernetes requesting merging the updated chart versions to the dev branch.

@blootsvoets
Copy link
Contributor

Some suggestions:

  • after applying yq, check if there is a diff. If not, create an output to indicate so and only run subsequent tasks if the output is true.
    if [ "$(git status --porcelain=v1 | wc -l)" > 0 ]; then
        echo "has_diff=true" >> $GITHUB_OUTPUT
    else
        echo "has_diff=false" >> $GITHUB_OUTPUT
    fi
  • Check if the pr already exists. If so, don't create but edit. Also reset the branch to the origin dev and add a fresh commit, removing the old commit.
  • Alternatively, create a PR on release, using GITHUB_REF to determine which chart to update. Each chart can have its own PR. This is more like dependabot.

@Bdegraaf1234
Copy link
Contributor

@keyvaann @pvannierop Can we revive this idea? How much work is left on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants