0.11.1-alpha.1 #30
0.11.1-alpha.1 #30
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 36.92% 37.10% +0.18%
==========================================
Files 279 276 -3
Lines 42804 41375 -1429
==========================================
- Hits 15804 15354 -450
+ Misses 27000 26021 -979
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@zoedberg thank you Can you please create a single tracking issue in |
|
Sure, done here RGB-WG/rgb#277. @dr-orlovsky What about the branch I asked you to push? Could you please give me the permission to push branches on https://github.com/RGB-WG/rgb so that I do not bother you every time I have to update an altered branch? |
|
@zoedberg sorry I can't even recall this matter... Too much stuff.. Github permissions are weird and constantly change. I added |
|
Yep, that helped, thank you! Now the altered repo is not pointing to my fork anymore. |
5f6b5f5 to
283e9cd
Compare
dad96a0 to
db77994
Compare
a66bd46 to
976d564
Compare
This PR updates the tests to the v0.11 fixes epic.
It shows how this epic is fixing known open bugs in v0.11.
The epic includes the following fixes/changes:
layer1chain-network pairhave contract commit to a close method(this became unnecessary after implementing seal unification)update_witnessesis not enough to handle reorgs rgb-std#296)this needs to be amended once https://github.com/zoedberg/rgb/tree/revert_fix_same_blinded_transfer gets published on the RGB-WG rgb repo (@dr-orlovsky could you do it or give me the permission to push branches there?)The epic is still missing:
INSTR_CONTRACT_TOconstant)(still discussing the best approach in Handle re-orgs BP-WG/bp-wallet#81)update_witnessesin a lightning wallet may disrupt channel operations rgb-std#292)and have the contract commit to an enum instead of a close method (e.g. TapretOnly, OpretOnly, 1stOpretThenTapret, 1stOpretOrTapret, etc)