tests/drivers/candev: minor cleanup #21175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99715d7 to
8d0ac30
Compare
benpicco
reviewed
Jan 30, 2025
maribu
commented
Mar 11, 2025
5bd3412 to
e6ad4dd
Compare
benpicco
approved these changes
Apr 2, 2025
97c65f8 to
71b4afc
Compare
crasbe
reviewed
Apr 5, 2025
- Do not hard code the number of the CAN interface to use. (This also allows specifying it via make command line / environment variable.) - Make less use of preprocessor and rely on compiler to eliminate dead branches and unused variables. Co-authored-by: crasbe <crasbe@gmail.com>
d8bfccd to
780a02e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Testing procedure
The test should behave as before. (Unless one would pass e.g.
CAN_DEV=1, in which case the 2nd CAN interface would be used instead of the first.)Issues/PRs references
None