Adding remaining flavors for grouped conv fwd #3436
Draft
+12,403
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect check and removed padding instances.
The descriptors are larger than needed (even though the compiler don't alloc registers for unused values).
…unction. Was necessary to pass the bias_clamp_large_cases test.
…zed to avoid undefined strides. Not convinced this struct is properly initialized in other code / future code.
…ty. Use this for grouped conv fwd but not in general.
…here in the repeated merging from develop.
…function can be used. Remove splitK, and forceThreadTileTransfer for now. Also add CShuffle epilogue argument.
…ds to be either fixed or removed.
…d-wmma-upstreamable
Co-authored-by: Bartłomiej Kocot <barkocot@amd.com>
…3 to only be used for f8, just in case it hurts performance.
30fd906 to
598d41e
Compare
Following flavors are updated with tuned instance list: - grouped_conv2d_fwd - grouped_conv2d_fwd_bias_clamp - grouped_conv2d_fwd_clamp - grouped_conv3d_fwd - grouped_conv3d_fwd_bias_clamp - grouped_conv3d_fwd_clamp - grouped_conv3d_fwd_scaleadd_ab Re-factored instance selection: - removed all the unnecessary instance tuples (comp/mem/16x16/generic) - removed all unnecessary layouts and data types
Base automatically changed from
streamhpc/grouped-conv-fwd-wmma-tuned-instances
to
streamhpc/grouped-conv-fwd-wmma
December 16, 2025 16:21
4b4d491 to
532329c
Compare
As titled. Following variants are added: - grouped_conv2d_fwd_dynamic_op - grouped_conv3d_fwd_dynamic_op - grouped_conv3d_fwd_bilinear - grouped_conv3d_fwd_convscale - grouped_conv3d_fwd_convinvscale - grouped_conv3d_fwd_convscale_add - grouped_conv3d_fwd_convscale_relu - grouped_conv3d_fwd_scale - grouped_conv3d_fwd_combconvscale - grouped_conv3d_fwd_scaleadd_scaleadd_relu
532329c to
0b0aa06
Compare
147d0f6 to
1983e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. Following variants are added:
Proposed changes
Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered