-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add DisableBackupNotifications parameter #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DisableBackupNotifications parameter #297
Conversation
- Disables network connectivity during Modern Standby sleep mode - Prevents battery drain caused by network activity during sleep - Addresses GitHub issue #268
- Enables Modern Standby networking disable for Sysprep mode - Allows enterprise deployments to include this optimization - Applies to default user profile for new user accounts
- Restores default Windows behavior for Modern Standby networking - Allows users to reverse the networking disable if needed - Enables network connectivity during sleep mode
- Enables command-line usage of Modern Standby networking disable - Maintains parameter consistency between Get.ps1 and main script - Supports automated deployment scenarios
- Informs users that Modern Standby networking will be disabled by default - Clarifies feature is Windows 11 specific - Improves transparency of default mode actions
- Add DisableModernStandbyNetworking parameter and switch case - Include Windows 11 version detection for feature availability - Add interactive menu option with descriptive prompt - Auto-enable in default mode for Windows 11 users - Resolves GitHub issue #268 regarding battery drain during sleep
|
Oops. |
|
Closing due to merge conflicts - will create clean implementation |
Clean Implementation SummaryThis PR adds Windows Backup notification disabling functionality. The commit history includes our previously merged Modern Standby commits due to branching from an outdated state - these can be ignored. Actual changes for this feature:
Files modified for backup notifications only:
Merge conflicts with master have been resolved. The feature is ready for review. |
|
@Raphire Sorry for the confusion with the messy commit history. I forgot to pull the latest changes and created this branch from an outdated state that still contained my previous merged Modern Standby commits. The actual backup notifications implementation is clean and follows the same patterns as the previous PR. Feature is ready for review; just ignore the duplicate commits from the earlier PR. |
|
@SashankBhamidi No wories about the extra commits, that's what you get when squashing PR's Thanks again for working on yet another nice feature. I am conflicted however if this is something that warrants being a separate option. I feel like it could work being a part of the catch-all Disable_Windows_Suggestions.reg. There's some overlap with some of the keys already in there. |
|
Right, @Raphire. Backup notifications are essentially Microsoft suggestions, so consolidating under DisableSuggestions makes perfect UX sense. I'll add the backup notification registry entries directly to the existing Disable_Windows_Suggestions.reg. |
|
@Raphire I've implemented your suggestion to consolidate backup notifications under the existing DisableSuggestions parameter. Changes made:
Now backup notifications are automatically disabled when users choose |
@SashankBhamidi That was quick! Looking good, although it missing the Sysprep key from the Undo regfile. |
Fix missing DisableMonitoring registry key in undo file to properly reverse system-wide backup monitoring changes from Sysprep version.
|
@Raphire Fixed! Added the missing HKLM DisableMonitoring key to the undo registry file. Thanks for the quick review and catch on that detail. |
|
@SashankBhamidi Thanks! Merged it :) |
Disables Windows Backup reminder notifications that appear in the system notification area.
Changes:
DisableBackupNotificationsparameterHKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Notifications\Settings\Windows.SystemToast.BackupReminderHKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsBackup\DisableMonitoringUsage: