Style #65
Merged
Style #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- packages/web/src/components/edit-folder-dialog.tsx: Evaluated as low risk
- packages/web/src/components/edit-tag-dialog.tsx: Evaluated as low risk
Comments suppressed due to low confidence (6)
packages/web/src/components/page-card.tsx:46
- The variable name 'showcaseSate' appears to be a typo. It should be renamed to 'showcaseState' to match the correct spelling.
const [showcaseSate, setShowcaseState] = useState(page.isShowcased)
packages/web/src/components/page-card.tsx:53
- The variable 'showcaseSate' should be 'showcaseState' to match the correct state variable name.
setShowcaseState(showcaseSate === 1 ? 0 : 1)
packages/web/src/components/page-card.tsx:152
- The variable 'showcaseSate' should be 'showcaseState' to match the correct state variable name.
updateShowcase({ id: page.id, isShowcased: showcaseSate === 1 ? 0 : 1 })
packages/web/src/components/page-card.tsx:156
- The variable 'showcaseSate' should be 'showcaseState' to match the correct state variable name.
showcaseSate === 1 ? <EyeOff className="w-5 h-5" /> : <Eye className="w-5 h-5" />
packages/web/src/components/page-card.tsx:163
- The variable 'showcaseSate' should be 'showcaseState' to match the correct state variable name.
showcaseSate === 1 ? 'Remove from showcase' : 'Show in showcase'
packages/web/src/components/new-folder-dialog.tsx:47
- Ensure that the new onKeyDown behavior is covered by tests to verify that pressing 'Enter' triggers the handleSubmit function correctly.
onKeyDown={e => e.key === 'Enter' && handleSubmit()}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add Enter key support for folder and tag input dialogs
style: use TooltipPortal to prevent TooltipContent from being incorrectly hidden
refactor: add BadgeSpan component and update usage in PageCard to avoid react validateDOMNesting error