Skip to content

fix: Optional authentication not rendered properly (#2117) #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexVarchuk merged 1 commit into from
Aug 17, 2022
Merged

fix: Optional authentication not rendered properly (#2117) #2134

AlexVarchuk merged 1 commit into from
Aug 17, 2022

Conversation

@zalewskigrzegorz
Copy link
Contributor

@zalewskigrzegorz zalewskigrzegorz commented Aug 16, 2022 •
edited
Loading

What/Why/How?

Representing optional authentication on endpoint don't display properly.
image
image

After fix

security:
  - {}
  - basic: []

or

security:
  - basic: []
  -  {}

Should be displayed properly

Reference

#2117

Testing

Unit test added
for manual testing, modify openapi.yaml

      security:
        - api_key: []

to

      security:
        - {}
        - api_key: []

Screenshots (optional)

image
image
image
image
image
image
image
image

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@zalewskigrzegorz zalewskigrzegorz requested a review from a team as a code owner August 16, 2022 23:45
@zalewskigrzegorz zalewskigrzegorz requested review from Oprysk and removed request for a team August 16, 2022 23:45
@AlexVarchuk AlexVarchuk merged commit efd5e09 into Redocly:master Aug 17, 2022
@Ernel1997 Ernel1997 mentioned this pull request Sep 13, 2022
Open
@AlexVarchuk AlexVarchuk mentioned this pull request Oct 4, 2022
Closed
@AlexVarchuk AlexVarchuk mentioned this pull request Oct 12, 2022
Closed
@dexterinbk dexterinbk mentioned this pull request Nov 28, 2023
Open
This was referenced Jul 16, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jul 25, 2024
Open
Open
Open
Open
Open
Open
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
This was referenced Aug 12, 2024
Open
Open
Open
This was referenced Aug 19, 2024
Open
Open
Open
Open
This was referenced Aug 26, 2024
Open
Open
Open
This was referenced Sep 6, 2024
Open
Open
Open
This was referenced Sep 23, 2024
Open
Open
Open
Open
This was referenced Oct 1, 2024
Open
Open
Open
Open
@mkajitansnyk mkajitansnyk mentioned this pull request Oct 24, 2024
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
@mkajitansnyk mkajitansnyk mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Oprysk Oprysk Oprysk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zalewskigrzegorz @Oprysk @AlexVarchuk