MOD-13142 config: accept ts-num-threads as load-time arg #1836
+68
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allow PYTHON override for flow tests, and add a regression test for ts-num-threads module args.
src/config.c
Outdated
| if (argc > 1 && RMUtil_ArgIndex("ts-num-threads", argv, argc) >= 0) { | ||
| long long parsed = TSGlobalConfig.numThreads; | ||
| if (RMUtil_ParseArgsAfter("ts-num-threads", argv, argc, "l", &parsed) != REDISMODULE_OK) { | ||
| RedisModule_Log(ctx, "warning", "Unable to parse argument after ts-num-threads"); |
Collaborator
There was a problem hiding this comment.
Should probably be an error log, not warning.
src/config.c
Outdated
| } | ||
| if (parsed < NUM_THREADS_MIN || parsed > NUM_THREADS_MAX) { | ||
| RedisModule_Log(ctx, | ||
| "warning", |
Collaborator
There was a problem hiding this comment.
Same (and all cases below that lead to a TSDB_ERROR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allow PYTHON override for flow tests, and add a regression test for ts-num-threads module args.
Note
Support
ts-num-threadsas a load-time module argument (validated, preferred overNUM_THREADS), add a regression test, and allow overriding the Python interpreter in flow tests.ts-num-threadsas a load-time argument with bounds validation; prefer it over deprecatedNUM_THREADSwhen both provided; initialize default and tighten error logging on parse/range failures.ts-num-threadsmodule argument setsCONFIG ts-num-threadsand is not flagged deprecated.tests/flow/tests.sh: allow overriding Python viaPYTHONenv (resolving relative paths) and use it to invoke RLTest.Written by Cursor Bugbot for commit 4bf8d4e. This will update automatically on new commits. Configure here.