Skip to content

Conversation

@kageurufu
Copy link

Borrowed from shiiion/dolphin#159

Fixes bugs noted in shiiion/dolphin#158

Based on changes from dolphin-emu/dolphin@c3b8aa1

@XargonWan
Copy link
Collaborator

Unfortunately now we are running on a non-merged PR of primehack, and considering that this fix should ve tested there is no way we can implement it in 0.8.4b as it's an hotfix.
We will merge everything in 0.9.0b when at least one of the two PRs is approved.

Thanks for the contribution, keeping it on hold for now.

@XargonWan XargonWan added External Development Needed 👁️‍🗨️ Development outside of RetroDECK is needed Bug: RetroDECK 🕷️ A confirmed bug in RetroDECK Review needed 🧑‍💻 A contribution that needs to be reviewed and merged by the RetroDECK Team labels Aug 6, 2024
@Fing3rSalad
Copy link

I just updated retrodeck to the latest version, and the inputs after closing primehack are still messed up.

@XargonWan
Copy link
Collaborator

The structure has changed as Primehack has been outsourced, if we need to patch, we need to patch there, but first better to check if the newest update (if contains the needed fixes for differentiating Primehack from Dolphin) is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug: RetroDECK 🕷️ A confirmed bug in RetroDECK External Development Needed 👁️‍🗨️ Development outside of RetroDECK is needed Review needed 🧑‍💻 A contribution that needs to be reviewed and merged by the RetroDECK Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants