fix: rare useEffect cycle with multiple tabs #37660

cardoso · 2025-12-01T20:49:10Z

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1543

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Bug Fixes
- Fixed duplicate language preference synchronization requests when updating user language settings.
Refactor
- Streamlined user language preference handling for improved reliability and reduced server calls.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

dionisio-bot · 2025-12-01T20:49:14Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2025-12-01T20:49:14Z

⚠️ No Changeset found

Latest commit: 8f8bd30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-01T20:49:17Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes refactor user language preference synchronization by extracting logic into a dedicated hook (useUserLanguageSync). The hook manages client-server language state using localStorage, a pending flag, and conditional queuing to prevent redundant setPreferences API calls in multi-tab scenarios.

Changes

Cohort / File(s)	Change Summary
UserProvider Refactor `apps/meteor/client/providers/UserProvider/UserProvider.tsx`	Removed direct language state management and manual localStorage synchronization logic. Replaced useEffect that mirrored language state with new useUserLanguageSync hook call. Simplified imports by removing useLocalStorage, useEndpoint, and related state setters.
Language Sync Hook `apps/meteor/client/providers/UserProvider/hooks/useUserLanguageSync.ts`	New hook introduced to handle user language synchronization. Manages client-side language state in localStorage with three tracked values: userLanguage, preferredLanguage, and pending sync flag. Implements conditional logic to queue server updates only when languages diverge, uses pendingLanguageRef for sequencing, and includes error handling on API requests.
E2E Test `apps/meteor/tests/e2e/user-preferences-loop.spec.ts`	New Playwright test module that validates language preference synchronization logic. Includes RequestTracker utility to count POST requests to /v1/users.setPreferences. Test simulates opening three tabs with different languages and verifies no additional setPreferences calls occur after the cascading tab-open sequence.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

The new useUserLanguageSync hook contains conditional state management logic with multiple branches (pending sync state, language divergence checks, server update queueing) that requires careful review to verify deduplication correctness and prevent edge-case failures
The dependency array and effect sequencing logic should be validated to ensure no unintended re-invocations or infinite loops
Error handling path in the server request needs verification that it properly cleans up the pending flag
The E2E test's RequestTracker implementation should be checked to confirm it reliably captures all POST requests to the target endpoint

Poem

🐰 When language preferences cause the browser to freeze,
We hook them up with state and localStorage ease!
With pending flags and debounce so fine,
No cascading requests will cross the line—
Three tabs open, one sync to bind them well! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: rare useEffect cycle with multiple tabs' directly addresses the primary objective of fixing the useEffect cycle issue that causes browser freezing with multiple tabs.
Linked Issues check	✅ Passed	The PR implementation introduces useUserLanguageSync hook to prevent duplicate setPreferences API calls, and includes an e2e test validating no additional calls occur after opening multiple tabs with different languages, addressing CORE-1543's requirement.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the useEffect cycle: UserProvider refactored to use new hook, useUserLanguageSync hook created for synchronized language updates, and e2e test added to validate the fix works correctly.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-01T21:05:17Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	358MiB	347MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	-161B
queue-worker-service	132MiB	132MiB	-503B
ddp-streamer-service	126MiB	126MiB	-766B
account-service	113MiB	113MiB	+647B
stream-hub-service	110MiB	110MiB	-368B
presence-service	110MiB	110MiB	+501B
authorization-service	110MiB	110MiB	-22B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 15:45", "12/16 16:06 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 22 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37660
Baseline: develop
Timestamp: 2025-12-16 16:06:55 UTC
Historical data points: 22

Updated: Tue, 16 Dec 2025 16:06:55 GMT

codecov · 2025-12-01T21:28:02Z

Codecov Report

❌ Patch coverage is 50.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.77%. Comparing base (cf4dfcd) to head (a2aaad1).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37660      +/-   ##
===========================================
+ Coverage    67.68%   67.77%   +0.09%     
===========================================
  Files         3457     3458       +1     
  Lines       113836   113858      +22     
  Branches     20909    20917       +8     
===========================================
+ Hits         77047    77171     +124     
+ Misses       34654    34549     -105     
- Partials      2135     2138       +3

Flag	Coverage Δ
e2e	`57.37% <50.00%> (+0.03%)`	⬆️
e2e-api	`43.25% <ø> (+0.99%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cardoso · 2025-12-16T12:14:54Z

@CodeRabbit review

coderabbitai · 2025-12-16T12:15:01Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 3

🧹 Nitpick comments (1)

apps/meteor/tests/e2e/user-preferences-loop.spec.ts (1)
51-67: Remove unused return values and fix misleading comment.

The test steps return page objects that are never used. Additionally, the comment on Line 63 states "should trigger the cascading loop," which contradicts the test's objective—verifying that the loop is prevented.

Apply this diff:
 await test.step('load the first tab', async () => {
   const page = await navigateToHomePage(context, 'de');
   requestTracker.track(page);
-  return page;
 });

 await test.step('load a second tab to ensure the baseline stays stable', async () => {
   const page = await navigateToHomePage(context, 'pt');
   requestTracker.track(page);
-  return page;
 });

-await test.step('opening a third tab should trigger the cascading loop', async () => {
+await test.step('open a third tab to verify no cascading loop occurs', async () => {
   const page = await navigateToHomePage(context, 'fr');
   requestTracker.track(page);
-  return page;
 });

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cf4dfcd and a2aaad1.

📒 Files selected for processing (3)

apps/meteor/client/providers/UserProvider/UserProvider.tsx (3 hunks)
apps/meteor/client/providers/UserProvider/hooks/useUserLanguageSync.ts (1 hunks)
apps/meteor/tests/e2e/user-preferences-loop.spec.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts
apps/meteor/client/providers/UserProvider/hooks/useUserLanguageSync.ts
apps/meteor/client/providers/UserProvider/UserProvider.tsx

**/*.spec.ts

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use .spec.ts extension for test files (e.g., login.spec.ts)

Files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

apps/meteor/tests/e2e/**/*.spec.ts

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

apps/meteor/tests/e2e/**/*.spec.ts: All test files must be created in apps/meteor/tests/e2e/ directory
Avoid using page.locator() in Playwright tests - always prefer semantic locators such as page.getByRole(), page.getByLabel(), page.getByText(), or page.getByTitle()
Use test.beforeAll() and test.afterAll() for setup/teardown in Playwright tests
Use test.step() for complex test scenarios to improve organization in Playwright tests
Group related tests in the same file
Utilize Playwright fixtures (test, page, expect) for consistency in test files
Prefer web-first assertions (toBeVisible, toHaveText, etc.) in Playwright tests
Use expect matchers for assertions (toEqual, toContain, toBeTruthy, toHaveLength, etc.) instead of assert statements in Playwright tests
Use page.waitFor() with specific conditions instead of hardcoded timeouts in Playwright tests
Implement proper wait strategies for dynamic content in Playwright tests
Maintain test isolation between test cases in Playwright tests
Ensure clean state for each test execution in Playwright tests
Ensure tests run reliably in parallel without shared state conflicts

Files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

apps/meteor/tests/e2e/**/*.{ts,spec.ts}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

apps/meteor/tests/e2e/**/*.{ts,spec.ts}: Store commonly used locators in variables/constants for reuse
Follow Page Object Model pattern consistently in Playwright tests

Files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

🧠 Learnings (17)

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Utilize Playwright fixtures (`test`, `page`, `expect`) for consistency in test files

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.{ts,spec.ts} : Follow Page Object Model pattern consistently in Playwright tests

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Maintain test isolation between test cases in Playwright tests

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use `test.step()` for complex test scenarios to improve organization in Playwright tests

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure clean state for each test execution in Playwright tests

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure tests run reliably in parallel without shared state conflicts

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Prefer web-first assertions (`toBeVisible`, `toHaveText`, etc.) in Playwright tests

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use `expect` matchers for assertions (`toEqual`, `toContain`, `toBeTruthy`, `toHaveLength`, etc.) instead of `assert` statements in Playwright tests

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use `test.beforeAll()` and `test.afterAll()` for setup/teardown in Playwright tests

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Implement proper wait strategies for dynamic content in Playwright tests

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-09-23T19:22:59.217Z

Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 36987
File: apps/meteor/tests/e2e/page-objects/fragments/room-toolbar.ts:10-20
Timestamp: 2025-09-23T19:22:59.217Z
Learning: In Playwright e2e tests, prefer stable selectors like data-qa-id attributes over localized text in getByRole() or getByText() calls to prevent test failures when UI language changes. Test translations separately by validating actual text content after ensuring UI interactions work with stable selectors.

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-11-24T17:08:17.065Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/page-objects/**/*.ts : Utilize existing page objects pattern from `apps/meteor/tests/e2e/page-objects/`

Applied to files:

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

📚 Learning: 2025-10-28T16:53:42.761Z

Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37205
File: ee/packages/federation-matrix/src/FederationMatrix.ts:296-301
Timestamp: 2025-10-28T16:53:42.761Z
Learning: In the Rocket.Chat federation-matrix integration (ee/packages/federation-matrix/), the createRoom method from rocket.chat/federation-sdk will support a 4-argument signature (userId, roomName, visibility, displayName) in newer versions. Code using this 4-argument call is forward-compatible with planned library updates and should not be flagged as an error.

Applied to files:

apps/meteor/client/providers/UserProvider/UserProvider.tsx

📚 Learning: 2025-11-27T17:56:26.050Z

Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37557
File: apps/meteor/client/views/admin/ABAC/AdminABACRooms.tsx:115-116
Timestamp: 2025-11-27T17:56:26.050Z
Learning: In Rocket.Chat, the GET /v1/abac/rooms endpoint (implemented in ee/packages/abac/src/index.ts) only returns rooms where abacAttributes exists and is not an empty array (query: { abacAttributes: { $exists: true, $ne: [] } }). Therefore, in components consuming this endpoint (like AdminABACRooms.tsx), room.abacAttributes is guaranteed to be defined for all returned rooms, and optional chaining before calling array methods like .join() is sufficient without additional null coalescing.

Applied to files:

apps/meteor/client/providers/UserProvider/UserProvider.tsx

📚 Learning: 2025-11-04T16:49:19.107Z

Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37377
File: apps/meteor/ee/server/hooks/federation/index.ts:86-88
Timestamp: 2025-11-04T16:49:19.107Z
Learning: In Rocket.Chat's federation system (apps/meteor/ee/server/hooks/federation/), permission checks follow two distinct patterns: (1) User-initiated federation actions (creating rooms, adding users to federated rooms, joining from invites) should throw MeteorError to inform users they lack 'access-federation' permission. (2) Remote server-initiated federation events should silently skip/ignore when users lack permission. The beforeAddUserToRoom hook only executes for local user-initiated actions, so throwing an error there is correct. Remote federation events are handled separately by the federation Matrix package with silent skipping logic.

Applied to files:

apps/meteor/client/providers/UserProvider/UserProvider.tsx

📚 Learning: 2025-09-25T09:59:26.461Z

Learnt from: Dnouv
Repo: RocketChat/Rocket.Chat PR: 37057
File: packages/apps-engine/src/definition/accessors/IUserRead.ts:23-27
Timestamp: 2025-09-25T09:59:26.461Z
Learning: AppUserBridge.getUserRoomIds in apps/meteor/app/apps/server/bridges/users.ts always returns an array of strings (mapping subscription documents to room IDs), never undefined, even when user has no room subscriptions.

Applied to files:

apps/meteor/client/providers/UserProvider/UserProvider.tsx

📚 Learning: 2025-09-25T09:59:26.461Z

Learnt from: Dnouv
Repo: RocketChat/Rocket.Chat PR: 37057
File: packages/apps-engine/src/definition/accessors/IUserRead.ts:23-27
Timestamp: 2025-09-25T09:59:26.461Z
Learning: AppUserBridge.getUserRoomIds in apps/meteor/app/apps/server/bridges/users.ts always returns an array of strings by mapping subscription documents to room IDs, never undefined, even when user has no room subscriptions.

Applied to files:

apps/meteor/client/providers/UserProvider/UserProvider.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: 🔨 Test Unit / Unit Tests
GitHub Check: 🔎 Code Check / TypeScript
GitHub Check: 🔎 Code Check / Code Lint
GitHub Check: 🔨 Test Storybook / Test Storybook
GitHub Check: 📦 Meteor Build (coverage)
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

🔇 Additional comments (2)

apps/meteor/client/providers/UserProvider/UserProvider.tsx (1)

87-87: Language sync refactoring looks good.

The refactoring successfully delegates language synchronization to the dedicated useUserLanguageSync hook, improving code organization and separation of concerns. The hook is called with the correct parameter, and the null case is properly handled.

apps/meteor/tests/e2e/user-preferences-loop.spec.ts (1)

77-86: No changes needed. The localStorage key 'fuselage-localStorage-preferedLanguage' in the test correctly matches the application code. Both the test and the app's useUserLanguageSync.ts hook consistently use this spelling ("prefered" rather than "preferred"), confirming the keys are properly synchronized.

apps/meteor/client/providers/UserProvider/hooks/useUserLanguageSync.ts

apps/meteor/tests/e2e/user-preferences-loop.spec.ts

cardoso changed the title ~~fix(autotranslate): reset state on logout~~ fix: rare useEffect cycle with multiple tabs Dec 8, 2025

cardoso force-pushed the fix/CORE-1543 branch 3 times, most recently from f85cf44 to 4789bad Compare December 9, 2025 13:09

cardoso added this to the 7.14.0 milestone Dec 9, 2025

cardoso force-pushed the fix/CORE-1543 branch from e909ba2 to a2aaad1 Compare December 16, 2025 12:14

coderabbitai bot reviewed Dec 16, 2025

View reviewed changes

apps/meteor/client/providers/UserProvider/hooks/useUserLanguageSync.ts Outdated Show resolved Hide resolved

apps/meteor/tests/e2e/user-preferences-loop.spec.ts Outdated Show resolved Hide resolved

apps/meteor/tests/e2e/user-preferences-loop.spec.ts Outdated Show resolved Hide resolved

cardoso force-pushed the fix/CORE-1543 branch 2 times, most recently from 145493c to 4d8c6ef Compare December 16, 2025 15:30

fix: rare useEffect cycle with multiple tabs

8f8bd30

cardoso force-pushed the fix/CORE-1543 branch from aba9327 to 8f8bd30 Compare December 16, 2025 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: rare useEffect cycle with multiple tabs #37660

fix: rare useEffect cycle with multiple tabs #37660

cardoso commented Dec 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

Review skipped

Uh oh!

github-actions bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

cardoso commented Dec 16, 2025

Uh oh!

coderabbitai bot commented Dec 16, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: rare useEffect cycle with multiple tabs #37660

Are you sure you want to change the base?

fix: rare useEffect cycle with multiple tabs #37660

Conversation

cardoso commented Dec 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

codecov bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cardoso commented Dec 16, 2025

Uh oh!

coderabbitai bot commented Dec 16, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cardoso commented Dec 1, 2025 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Dec 1, 2025 •

edited

Loading

changeset-bot bot commented Dec 1, 2025 •

edited

Loading

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading

codecov bot commented Dec 1, 2025 •

edited

Loading