Clean up constantly initialized class members #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
hopefully none
Description
There are a number of places where class members were being declared in the constructor and assigned to constant values that could easily be moved up into the class definition itself - when I converted everything to classes from prototypes, I just used the automatic refactor in VS Code, which wasn't smart enough to extract these. This PR moves them to the class definition and deals with the fallout of TypeScript being able to better-understand their types now.
It also goes around and removes the old
that = thisworkaround that was popular before arrow functions allowed scope capture for callbacks and replaces those classic functions with arrow functions.