Fix num_env_step not working in RolloutWrapper issue #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #79
environment made by RolloutWrapper doesn't reflect
num_env_stepvariable which we put intoRolloutWrapper:Code for reproduction
Why this bug happened?
RolloutWrapper.single_rollout()putsself.env_params.max_steps_in_episodeinjax.lax.scan()instead ofself.num_env_steps(gymnax/experimental/rollout.py#L94).num_env_stepsas sames as enviornment'smax_steps_in_episodefor testing this feature (gymnax/tests/wrappers/test_evaluator.py).What is fixed in this PR?
self.env_params.max_steps_in_episodetoself.num_env_stepsinRolloutWrapper.single_rollout()>jax.lax.scan().