Add component name to property validation error message #275
Conversation
ZoteTheMighty
left a comment
There was a problem hiding this comment.
Can we add a test for this? Might just be able to modify this test:
Probably would need to replace the expect...to.throw with a pcall and do some assertions on the error message.
ZoteTheMighty
left a comment
There was a problem hiding this comment.
This looks good to me! Any objections, @LPGhatguy ?
| expect(success).to.equal(false) | ||
| expect(error:find("MyComponent")).to.be.ok() | ||
| local startIndex = error:find("MyComponent") | ||
| expect(startIndex).to.be.ok() |
There was a problem hiding this comment.
Oh, good catch here!
|
@cliffchapmanrbx Looks like this CLA check doesn't work with forks, not sure if we need to change it? Edit: Okay, so it just requires a comment to be made before it makes the comment. Should I just add myself to the whitelist or respond to the bot? |
|
CLA Signature Action: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to our company's repositories. 0 out of 1 committers have signed the CLA. |
|
Minor deployment bugs on the bot that I fixed late yesterday, it should work normally now. As it says at http://go/clabot FTEs should not sign the CLA, they should be whitelisted. |
LPGhatguy
left a comment
There was a problem hiding this comment.
Looks good to me after a small changelog suggestion.
Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
Add componentName to property validation error message. This would be helpful in cases where element tracing is not turned on or provides an unhelpful error message.
Checklist before submitting:
CHANGELOG.md