This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Follow style guide + Luau performance guide #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthargett
reviewed
May 12, 2021
Contributor
matthargett
left a comment
There was a problem hiding this comment.
Thanks for the contribution! A few minor requests, and then we can review again.
| if config.typeChecks then | ||
| assert(Type.of(element) == Type.Element, "Expected arg #1 to be of type Element") | ||
| assert(renderer.isHostObject(hostParent) or hostParent == nil, "Expected arg #2 to be a host object") | ||
| assert(hostParent == nil or renderer.isHostObject(hostParent), "Expected arg #2 to be a host object") |
Contributor
There was a problem hiding this comment.
if you're changing these a bit, can you also make them say something more specific like:
"Expected the hostParent argument to mountVirtualTree to be a Host Object."?
| local TextReverser = Roact.Component:extend("TextReverser") | ||
|
|
||
| function TextReverser:init() | ||
| self.state = { |
Contributor
There was a problem hiding this comment.
we may be changing our guidance on this in the future, so leave this one for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made the following changes to the codebase, as seen in the changelog.
string.xinstead of:x).Checklist before submitting:
CHANGELOG.md