Skip to content

Conversation

@aullman
Copy link

@aullman aullman commented Jul 21, 2025

Gemma3 Support

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

This is related to the MedGemma PR. Gemma 3 models like medgemma were not supported in the older version of mlx-swift-examples. Had to update to the latest 2.25.5 to get gemma3 support.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

  • Update to latest version of mlx-swift-examples 2.25.5 to support gemma3.
  • Update to latest version of mlx-swift (0.25.5)
  • Pass extraEOSTokens to the ModelConfiguration. This is required to pass "<end_of_turn>" to the gemma3 models to get them to stop properly. See this issue.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

Don't need to update any docs, just updating versions.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Don't need to update any tests, just updating versions.

📝 Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.66%. Comparing base (ca2165e) to head (fdb5695).
Report is 5 commits behind head on medgemma.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           medgemma     #120   +/-   ##
=========================================
  Coverage     43.66%   43.66%           
=========================================
  Files            66       66           
  Lines           465      465           
=========================================
  Hits            203      203           
  Misses          262      262           
Files with missing lines Coverage Δ
Sources/SpeziLLMLocal/LLMLocalSchema.swift 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2165e...fdb5695. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishnuravi vishnuravi changed the base branch from main to medgemma July 22, 2025 03:44
@vishnuravi
Copy link
Member

Thank you @aullman!

@vishnuravi vishnuravi self-requested a review July 23, 2025 00:48
@vishnuravi vishnuravi merged commit 8005eb9 into StanfordSpezi:medgemma Jul 23, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants