[Feature] Implement user identity impersonation for the Iceberg REST catalog using the OIDC token + Iceberg token exchange flow #57443
+2,827
−405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return icebergCatalog.tableExists(context, dbName, tblName); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
The most risky bug in this code is:
Inconsistent Use of ConnectContext in alterView
You can modify the code like this:
Database db = getDb(context, stmt.getDbName());| return new SessionCatalog.SessionContext(sessionId, context.getQualifiedUser(), credentials, ImmutableMap.of(), | ||
| context.getCurrentUserIdentity()); | ||
| } | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
The convertContext method overwrites credentials in a way that might not include required keys if context.getAuthToken() is non-empty, potentially breaking authentication.
You can modify the code like this:
private SessionCatalog.SessionContext convertContext(ConnectContext context) {
String sessionId = format("%s-%s", context.getQualifiedUser(), context.getSessionId());
Map<String, String> baseCredentials = Maps.filterKeys(securityProperties.get(), key -> Set.of(TOKEN, CREDENTIAL).contains(key));
Map<String, String> credentials;
if (Strings.isNullOrEmpty(context.getAuthToken())) {
credentials = baseCredentials;
} else {
credentials = ImmutableMap.<String, String>builder()
.putAll(baseCredentials)
.put(OAuth2Properties.ACCESS_TOKEN_TYPE, context.getAuthToken())
.build();
}
return new SessionCatalog.SessionContext(sessionId, context.getQualifiedUser(), credentials, ImmutableMap.of(),
context.getCurrentUserIdentity());
}
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 107 / 126 (84.92%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
##57024
Implement user identity impersonation for the Iceberg REST catalog using the OIDC token + Iceberg token exchange flow.
I have already conducted tests using OKTA + Nessie.
example:
What I'm doing:
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: