Skip to content

[BugFix] implement hashCode and equalsWithoutChild for InformationFunction #59182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
silverbullet233 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[BugFix] implement hashCode and equalsWithoutChild for InformationFunction #59182

silverbullet233 wants to merge 3 commits into from
+38 −0

Conversation

@silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented May 21, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #59183

root cause:
we didn't implement hashCode and equals method for InformationFunction, so it will get wrong result when putting them into outputTranslations in QueryTransformer, resulting a wrong outputColumns of the final logical plan.
image

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@silverbullet233
implement hashCode and equalsWithoutChild for InformationFunction
96cf8e3 
Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
@silverbullet233 silverbullet233 requested a review from a team as a code owner May 21, 2025 06:24
@silverbullet233 silverbullet233 changed the title [BugFIx] implement hashCode and equalsWithoutChild for InformationFunction [BugFix] implement hashCode and equalsWithoutChild for InformationFunction May 21, 2025
@kangkaisen
Copy link
Collaborator

kangkaisen commented May 21, 2025

please add test cases.

@silverbullet233
add ut
f85044d 
Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
@silverbullet233
fix
1836ad2 
Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 22, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions
Copy link

github-actions bot commented May 22, 2025

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions
Copy link

github-actions bot commented May 22, 2025

[FE Incremental Coverage Report]

✅ pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/analysis/InformationFunction.java 5 5 100.00% []

@github-actions
Copy link

github-actions bot commented May 22, 2025

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@silverbullet233
Copy link
Contributor Author

silverbullet233 commented Oct 28, 2025

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2025

rebase

❌ Base branch update has failed

Details

Git reported the following error:

Rebasing (1/3)
Auto-merging fe/fe-core/src/main/java/com/starrocks/sql/ast/expression/InformationFunction.java
CONFLICT (content): Merge conflict in fe/fe-core/src/main/java/com/starrocks/sql/ast/expression/InformationFunction.java
error: could not apply 96cf8e3c76... implement hashCode and equalsWithoutChild for InformationFunction
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 96cf8e3c76... implement hashCode and equalsWithoutChild for InformationFunction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@silverbullet233 silverbullet233

Labels

3.3 3.4 3.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

select multiple information functions will get wrong result

2 participants

@silverbullet233 @kangkaisen