[BugFix] fix json length check (backport #66628) #66707
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Contributor
Author
Contributor
|
@Mergifyio rebase |
(cherry picked from commit ed8b59b)
Contributor
Author
✅ Branch has been successfully rebased |
c6c7f43 to
658424c
Compare
Contributor
|
@cursor review |
Contributor
|
@Mergifyio rebase |
Contributor
Author
☑️ Nothing to do, the required conditions are not metDetails
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Minimal length is 1024, which should be allowed.
Fixes #https://github.com/StarRocks/StarRocksTest/issues/10673
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Permits schema change from JSON to CHAR/VARCHAR when target length equals the JSON minimum (e.g., 1024).
Column.checkSchemaChangeAllowed, relax JSON length check: change<=to<so converting JSON toCHAR/VARCHARis allowed when targetstrLenequalsPrimitiveType.JSON.getTypeSize().Written by Cursor Bugbot for commit b81f3cd. This will update automatically on new commits. Configure here.
This is an automatic backport of pull request #66628 done by [Mergify](https://mergify.com).
Note
Relax JSON length validation to allow JSON → CHAR/VARCHAR when target length equals the JSON minimum size.
fe/fe-core/src/main/java/com/starrocks/catalog/Column.checkSchemaChangeAllowed:CHAR/VARCHARlength check by changing<=to<, allowing targetstrLenequal toPrimitiveType.JSON.getTypeSize().Written by Cursor Bugbot for commit 658424c. This will update automatically on new commits. Configure here.