[Feature] support regex_instr #36958

liuzhixing1006 · 2023-12-13T08:32:31Z

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

CLAassistant · 2023-12-13T08:32:40Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Conflicts: be/test/exprs/string_fn_test.cpp

liuzhixing1006 · 2023-12-13T09:12:38Z

This resolves #19616

docs/en/sql-reference/sql-functions/like-predicate-functions/regexp_instr.md

be/test/exprs/string_fn_test.cpp

fzhedu · 2023-12-13T09:38:28Z

docs/en/sql-reference/sql-functions/like-predicate-functions/regexp_instr.md

+## Syntax
+
+```Haskell
+VARCHAR regexp_instr(VARCHAR str, VARCHAR pattern)


return int or bigint? what's the range?

docs/en/sql-reference/sql-functions/like-predicate-functions/regexp_instr.md

be/src/exprs/string_functions.cpp

satanson · 2023-12-13T09:34:10Z

gensrc/script/functions.py

     'StringFunctions::regexp_extract_prepare', 'StringFunctions::regexp_close'],
+    [30322, 'regexp_instr', 'INT', ['VARCHAR', 'VARCHAR'], 'StringFunctions::regexp_instr',
+     'StringFunctions::regexp_instr_prepare', 'StringFunctions::regexp_close'],
    [30330, 'regexp_replace', 'VARCHAR', ['VARCHAR', 'VARCHAR', 'VARCHAR'], 'StringFunctions::regexp_replace',


re-range the functions in the ascend order of function ID(s)

be/test/exprs/string_fn_test.cpp

satanson · 2023-12-13T09:40:29Z

be/src/exprs/string_functions.cpp

+        context->set_error(error.str().c_str());
+        return Status::InvalidArgument(error.str());
+    }
+


Take into consideration that the zeroth argument is also constant. for an example

select regex_instr('abcdef', 'ab[cd]*') from a_very_large_table

or implement constant folding of this function is ScalarOperatorFunctions.java

be/src/exprs/string_functions.cpp

docs/zh/sql-reference/sql-functions/like-predicate-functions/regexp_instr.md

…gexp_instr Conflicts: be/src/exprs/string_functions.cpp

liuzhixing1006 added 5 commits December 9, 2023 22:54

FE Commit: support regexp_instr function

5ccac3d

BE Commit: support regexp_instr function

a979d74

BE

bca5f4b

be commit: Add doc & Update some response body

834ff78

BE Commit: add CN-doc

1f9e536

liuzhixing1006 requested a review from a team as a code owner December 13, 2023 08:32

github-actions bot added the documentation Improvements or additions to documentation label Dec 13, 2023

mergify bot assigned liuzhixing1006 Dec 13, 2023

liuzhixing1006 mentioned this pull request Dec 13, 2023

[function]regexp_instr #19616

Closed

liuzhixing1006 changed the title ~~[Feature] support regex_instr #19616~~ [Feature] support regex_instr Dec 13, 2023

Merge remote-tracking branch 'upstream/main' into regexp_instr

a62a2b6

Conflicts: be/test/exprs/string_fn_test.cpp