Update renamed filename in protos.csv #1606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The renaming happened between 1348c75...269a4de
psychonic
reviewed
Dec 3, 2025
| dota2,dota_gcmessages_client_tournament.proto,GC\Dota\MsgGCClientTournament.cs,SteamKit2.GC.Dota.Internal | ||
| dota2,dota_gcmessages_client_watch.proto,GC\Dota\MsgGCClientWatch.cs,SteamKit2.GC.Dota.Internal | ||
| dota2,dota_gcmessages_common.proto,GC\Dota\MsgGCCommon.cs,SteamKit2.GC.Dota.Internal | ||
| dota2,dota_gcmessages_common_battle_report.proto,GC\Dota\MsgMCClientBattleReport.cs,SteamKit2.GC.Dota.Internal |
Member
There was a problem hiding this comment.
It would probably make sense to adjust the generated filename accordingly, as well
Author
There was a problem hiding this comment.
It would probably make sense to adjust the generated filename accordingly, as well
Indeed. I was worrying about introducing breaking changes, then I just checked and it seems this file is not referenced in other code.
Should I just change generated filename in this line, or also update the corresponding generated file, or with the updated protobuf submodule and all other generated files?
EDIT: I just found the file steammessages_clientserver_ufs.proto at line 25 got deleted and not yet readded like the battle report one. I think I should leave it be for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The renaming happened between 1348c75...269a4de
dota2/{dota_gcmessages_client_battle_report.proto → dota_gcmessages_common_battle_report.proto}