Upgrade Sonata to version 4 #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
commented
Apr 28, 2022
jordisala1991
commented
Apr 29, 2022
jordisala1991
commented
Apr 29, 2022
backend/src/Admin/UserAdmin.php
Outdated
|
|
||
| protected function configureFormFields(FormMapper $form): void | ||
| { | ||
| if (!$this->hasSubject()) { |
Member
Author
There was a problem hiding this comment.
This particular case to me it is not correct this way. I would rather do:
$required = !$this->hasSubject() || null === $this->getSubject()->getId();
jordisala1991
commented
Apr 29, 2022
Member
Author
jordisala1991
left a comment
There was a problem hiding this comment.
Only a minor change, the rest looks great
aerrasti
approved these changes
Apr 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Part of #50 .