Skip to content

Some issues when choose "Default to system" preference, system in dark theme #1288

Description

@Geeyun-JY3
  • Browser: Cent Browser 4.3.9.248 (64-bit) (Chromium 86.0.4240.198), Chrome 87.0.4280.141 (Official Build) (64-bit)
  • Operating System: Windows 10 20H2 19042.685
  • Link to page with the issue: any issue (listing) page, https://github.com/notifications
  • Screenshot:
    • Inbox "All caught up!" picture is not styled properly:
      image
    • Labels are still the GitHub native dark theme style

Activity

  1. Mottie commented on Jan 10, 2021

    @Mottie
    Member

    Hi @Geeyun-JY3!

    Please make sure your style is up-to-date.

    Also, I've noticed a difference between choosing GitHub's light vs dark theme. I prefer the light theme as a base for GitHub Dark

    Light
    2021-01-10 08_37_02-Notifications
    Dark
    2021-01-10 08_38_45-Notifications
  2. Geeyun-JY3 commented on Jan 10, 2021

    @Geeyun-JY3
    Author

    Please make sure your style is up-to-date.

    Yes I am pretty sure.

    When I choose "Light" or "Dark" in "Setting > Appearance > Theme", it looks the same as screenshots you have posted. But when I choose "Default to system", it really looks like this:
    image

    BTW, I am using WinDynamicDesktop to changes Windows 10 app theme based on the time of day. I don't know if it is related.

  3. the-j0k3r commented on Jan 10, 2021

    @the-j0k3r
    Member

    BTW, I am using WinDynamicDesktop to changes Windows 10 app theme based on the time of day. I don't know if it is related.

    BTW shouldn't you disable that and test, then youll know.

  4. Geeyun-JY3 commented on Jan 10, 2021

    @Geeyun-JY3
    Author

    BTW shouldn't you disable that and test, then youll know.

    Tested. I manually changed the default app mode in "Setting > Personalization > Colors", from "Light" to "Dark", then I got the same result. It is not related to WinDynamicDesktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug 🐛Something isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions