Skip to content

Fix invalid use of count by checking for an array #9204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pamil merged 1 commit into from
Feb 19, 2018
Merged

Fix invalid use of count by checking for an array #9204

pamil merged 1 commit into from
Feb 19, 2018

Conversation

@vntw
Copy link
Contributor

@vntw vntw commented Feb 19, 2018

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #9159
License MIT

Not sure if/how to test this in a model CallbackTransformer.

@pamil pamil added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Feb 19, 2018
@pamil pamil added this to the 1.0 milestone Feb 19, 2018
@pamil pamil merged commit 7a72e76 into Sylius:1.0 Feb 19, 2018
@pamil
Copy link
Contributor

pamil commented Feb 19, 2018

Thanks @venyii! 🎉

@pamil pamil mentioned this pull request Feb 19, 2018
Closed
@vntw vntw deleted the fix-count-array branch February 19, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pamil pamil pamil approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vntw @pamil @Zales0123