[Grid] Filtering orders bug #9284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bf9655 to
70184c5
Compare
lchrusciel
approved these changes
Mar 28, 2018
Contributor
|
Can we add a test for filtering something made on either 00:00:00 and 23:59:59? |
70184c5 to
361157d
Compare
Contributor
Author
|
@pamil done |
pamil
approved these changes
Apr 10, 2018
Contributor
|
Thank you Matt! 🎋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was reporter on Twitter 🐦 by Nick Chambers. I'm not 100% sure about this approach, as it requires providing default time in both form type and filter itself. Nevertheless, it works nice (as shown in scenario). I assume that proposed approach (
00:00as default time for from and23:59as default time for to) should be appropriate for most cases :)